Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 19693009: Prevent WebMediaPlayerImpl from dereferencing stale Frame pointers on Document changes. (Closed)

Created:
7 years, 5 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 5 months ago
Reviewers:
adamk
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, vcarbune.chromium, adamk+blink_chromium.org
Visibility:
Public.

Description

Prevent WebMediaPlayerImpl from dereferencing stale Frame pointers on Document changes. Temporary fix to prevent dereferencing stale Frame pointers when an HTMLMediaElement is moved from one document to another. (e.g., Lifting it out of an iframe into the main document.) BUG=260156 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154696

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Change fix so media/adopt-node-crash.html LayoutTest passes. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 2 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
acolwell GONE FROM CHROMIUM
This is a minimal fix that should fix a whole class potential crashes. This is ...
7 years, 5 months ago (2013-07-19 17:49:11 UTC) #1
acolwell GONE FROM CHROMIUM
@adamk could you take a quick look at this please.
7 years, 5 months ago (2013-07-19 19:21:09 UTC) #2
adamk
lgtm
7 years, 5 months ago (2013-07-22 21:28:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/19693009/13001
7 years, 5 months ago (2013-07-22 21:37:25 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-22 23:46:58 UTC) #5
Message was sent while issue was closed.
Change committed as 154696

Powered by Google App Engine
This is Rietveld 408576698