Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 19690005: add IMM32Manager::SetTextInputMode() function (Closed)

Created:
7 years, 5 months ago by yoichio
Modified:
7 years, 4 months ago
CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org, kochi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

add IMM32Manager::SetTextInputMode() function. This function changes IME conversion status corresponding to |input_mode| such as "latin", "katakana". BUG=244688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214577

Patch Set 1 : update #

Total comments: 6

Patch Set 2 : split function #

Total comments: 27

Patch Set 3 : update #

Total comments: 6

Patch Set 4 : nit pick #

Patch Set 5 : add comment #

Patch Set 6 : treat latin* as same as default #

Total comments: 8

Patch Set 7 : nit picks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -0 lines) Patch
M ui/base/ime/ime_unittests.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/base/ime/win/imm32_manager.h View 1 2 3 4 5 6 3 chunks +11 lines, -0 lines 0 comments Download
M ui/base/ime/win/imm32_manager.cc View 1 2 3 4 5 6 2 chunks +54 lines, -0 lines 0 comments Download
A ui/base/ime/win/imm32_manager_unittest.cc View 1 2 3 4 5 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
yoichio
Could you review?
7 years, 5 months ago (2013-07-22 09:31:35 UTC) #1
yoichio
7 years, 5 months ago (2013-07-23 02:03:09 UTC) #2
Yohei Yukawa
https://codereview.chromium.org/19690005/diff/16001/ui/base/ime/win/imm32_manager.cc File ui/base/ime/win/imm32_manager.cc (right): https://codereview.chromium.org/19690005/diff/16001/ui/base/ime/win/imm32_manager.cc#newcode533 ui/base/ime/win/imm32_manager.cc:533: | IME_CMODE_LANGUAGE Why do we need IME_CMODE_LANGUAGE? AFAIK, IME_CMODE_LANGUAGE ...
7 years, 5 months ago (2013-07-25 06:53:29 UTC) #3
yoichio
Get out ConvertInputModetoImmFlags from SetTextInputMode. https://chromiumcodereview.appspot.com/19690005/diff/16001/ui/base/ime/win/imm32_manager.cc File ui/base/ime/win/imm32_manager.cc (right): https://chromiumcodereview.appspot.com/19690005/diff/16001/ui/base/ime/win/imm32_manager.cc#newcode533 ui/base/ime/win/imm32_manager.cc:533: | IME_CMODE_LANGUAGE On 2013/07/25 ...
7 years, 5 months ago (2013-07-26 03:41:04 UTC) #4
Yohei Yukawa
Added nona@ for hearing comment at early state. https://chromiumcodereview.appspot.com/19690005/diff/22001/ui/base/ime/win/imm32_manager.h File ui/base/ime/win/imm32_manager.h (right): https://chromiumcodereview.appspot.com/19690005/diff/22001/ui/base/ime/win/imm32_manager.h#newcode243 ui/base/ime/win/imm32_manager.h:243: // ...
7 years, 5 months ago (2013-07-26 04:06:05 UTC) #5
Yohei Yukawa
Added nona@ for hearing comment at early state. https://chromiumcodereview.appspot.com/19690005/diff/22001/ui/base/ime/win/imm32_manager.h File ui/base/ime/win/imm32_manager.h (right): https://chromiumcodereview.appspot.com/19690005/diff/22001/ui/base/ime/win/imm32_manager.h#newcode243 ui/base/ime/win/imm32_manager.h:243: // ...
7 years, 5 months ago (2013-07-26 04:06:05 UTC) #6
yoichio
https://chromiumcodereview.appspot.com/19690005/diff/22001/ui/base/ime/win/imm32_manager.h File ui/base/ime/win/imm32_manager.h (right): https://chromiumcodereview.appspot.com/19690005/diff/22001/ui/base/ime/win/imm32_manager.h#newcode243 ui/base/ime/win/imm32_manager.h:243: // Get parameters for ::ImmSetOpenStatus and ::ImmSetConversionStatus from On ...
7 years, 5 months ago (2013-07-26 05:38:15 UTC) #7
Yohei Yukawa
https://codereview.chromium.org/19690005/diff/29002/ui/base/ime/win/imm32_manager.cc File ui/base/ime/win/imm32_manager.cc (right): https://codereview.chromium.org/19690005/diff/29002/ui/base/ime/win/imm32_manager.cc#newcode523 ui/base/ime/win/imm32_manager.cc:523: return; nit: indent https://codereview.chromium.org/19690005/diff/29002/ui/base/ime/win/imm32_manager_unittest.cc File ui/base/ime/win/imm32_manager_unittest.cc (right): https://codereview.chromium.org/19690005/diff/29002/ui/base/ime/win/imm32_manager_unittest.cc#newcode37 ui/base/ime/win/imm32_manager_unittest.cc:37: ...
7 years, 5 months ago (2013-07-26 06:38:49 UTC) #8
yoichio
https://chromiumcodereview.appspot.com/19690005/diff/29002/ui/base/ime/win/imm32_manager.cc File ui/base/ime/win/imm32_manager.cc (right): https://chromiumcodereview.appspot.com/19690005/diff/29002/ui/base/ime/win/imm32_manager.cc#newcode523 ui/base/ime/win/imm32_manager.cc:523: return; On 2013/07/26 06:38:49, Yohei Yukawa wrote: > nit: ...
7 years, 5 months ago (2013-07-26 06:57:14 UTC) #9
Yohei Yukawa
> https://chromiumcodereview.appspot.com/19690005/diff/29002/ui/base/ime/win/imm32_manager_unittest.cc#newcode37 > ui/base/ime/win/imm32_manager_unittest.cc:37: TRUE, > On 2013/07/26 06:38:49, Yohei Yukawa wrote: > > Is ...
7 years, 5 months ago (2013-07-26 07:07:09 UTC) #10
yoichio
On 2013/07/26 07:07:09, Yohei Yukawa wrote: > > > https://chromiumcodereview.appspot.com/19690005/diff/29002/ui/base/ime/win/imm32_manager_unittest.cc#newcode37 > > ui/base/ime/win/imm32_manager_unittest.cc:37: TRUE, > ...
7 years, 5 months ago (2013-07-26 08:28:39 UTC) #11
yukawa_g
lgtm lgtm
7 years, 5 months ago (2013-07-26 08:51:16 UTC) #12
yukawa_g
lgtm
7 years, 5 months ago (2013-07-26 08:51:17 UTC) #13
Yohei Yukawa
7 years, 5 months ago (2013-07-26 08:57:03 UTC) #14
Yohei Yukawa
lgtm
7 years, 5 months ago (2013-07-26 08:57:19 UTC) #15
yoichio
ping nona@?
7 years, 4 months ago (2013-07-30 02:19:36 UTC) #16
Seigo Nonaka
lgtm lgtm, mostly style nits. https://codereview.chromium.org/19690005/diff/65001/ui/base/ime/win/imm32_manager.cc File ui/base/ime/win/imm32_manager.cc (right): https://codereview.chromium.org/19690005/diff/65001/ui/base/ime/win/imm32_manager.cc#newcode526 ui/base/ime/win/imm32_manager.cc:526: BOOL open; please initialize. ...
7 years, 4 months ago (2013-07-30 20:46:44 UTC) #17
yoichio
Thanks! https://chromiumcodereview.appspot.com/19690005/diff/65001/ui/base/ime/win/imm32_manager.cc File ui/base/ime/win/imm32_manager.cc (right): https://chromiumcodereview.appspot.com/19690005/diff/65001/ui/base/ime/win/imm32_manager.cc#newcode526 ui/base/ime/win/imm32_manager.cc:526: BOOL open; On 2013/07/30 20:46:45, Seigo Nonaka wrote: ...
7 years, 4 months ago (2013-07-31 01:11:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/19690005/75001
7 years, 4 months ago (2013-07-31 01:37:26 UTC) #19
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 05:36:06 UTC) #20
Message was sent while issue was closed.
Change committed as 214577

Powered by Google App Engine
This is Rietveld 408576698