media: Make media mojo services a component

media/mojo/services/mojo_cdm_allocator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_MOJO_SERVICES_MOJO_CDM_ALLOCATOR_H_
 #define MEDIA_MOJO_SERVICES_MOJO_CDM_ALLOCATOR_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_checker.h"
 #include "media/cdm/cdm_allocator.h"
+#include "media/mojo/services/media_mojo_export.h"
 #include "mojo/public/cpp/system/buffer.h"
 
 namespace media {
 
 // This is a CdmAllocator that creates buffers using mojo shared memory.
 // The internal logic is similar to ppapi_cdm_buffer.cc.
-class MojoCdmAllocator : public CdmAllocator {
+class MEDIA_MOJO_EXPORT MojoCdmAllocator : public CdmAllocator {

[ddorwin, 2016/05/11 23:02:28]

Why wasn't this necessary before? Do we really want to export it if it wasn't
necessary before?

[xhwang, 2016/05/16 05:41:21]

Previously we use a source_set, where this file will always be statically linked
into the depending target, so there's no need to export anything. Now we are
using a component, which will be a shared library in component builds. We need
XXX_EXPORT for unittest (we have a test for this class).

  public:
   MojoCdmAllocator();
   ~MojoCdmAllocator() final;
 
   // CdmAllocator implementation.
   cdm::Buffer* CreateCdmBuffer(size_t capacity) final;
   std::unique_ptr<VideoFrameImpl> CreateCdmVideoFrame() final;
 
  private:
   friend class MojoCdmAllocatorTest;
@@ skipping 28 matching lines @@
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<MojoCdmAllocator> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MojoCdmAllocator);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_MOJO_SERVICES_MOJO_CDM_ALLOCATOR_H_