media: Make media mojo services a component

content/gpu/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//media/media_options.gni")
 
 # See //content/BUILD.gn for how this works.
 group("gpu") {
   visibility = [ "//content/*" ]  # This is an internal content API.
@@ skipping 39 matching lines @@
     "//content/child",
     "//content/common",
     "//content/public/child:child_sources",
     "//content/public/common:common_sources",
     "//gpu:gpu",
     "//gpu/ipc/common:command_buffer_traits",
     "//gpu/ipc/service",
     "//ipc",
     "//media/gpu",
     "//media/gpu/ipc/service",
-    "//media/mojo/services:application_factory",

[xhwang, 2016/05/12 06:32:25]

+brettw: This was added in https://codereview.chromium.org/1833193002, even
though we have the conditional deps below at line 69. And in the source code we
have a conditional include.

Are we preferring unconditional deps to nogncheck now?

     "//services/shell/public/interfaces",
     "//skia",
     "//ui/events/ipc",
     "//ui/gfx/ipc",
     "//ui/gl",
   ]
 
   if (mojo_media_host == "gpu") {
-    deps += [ "//media/mojo/services:application_factory" ]
+    deps += [ "//media/mojo/services" ]

[ddorwin, 2016/05/11 23:02:27]

This was previously always included. Was that incorrect?

[xhwang, 2016/05/16 05:41:20]

We should either only always include, or only conditional include. I think
conditional include makes more sense.

     if (is_android) {
       deps += [ "//media/base/android" ]
     }
   }
 
   if (is_win) {
     configs += [
       "//third_party/khronos:khronos_headers",
       "//third_party/wtl:wtl_includes",
     ]
@@ skipping 14 matching lines @@
   }
 
   if (use_ozone) {
     deps += [ "//ui/ozone" ]
   }
 
   if (enable_vulkan) {
     deps += [ "//gpu/vulkan" ]
   }
 }