Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 19685007: Move android filename rules to appropriate gypi file (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Move android filename rules to appropriate gypi file We should only define filename based rules in filename_rules.gypi so it only affects chromium source. BUG=none R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212890

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M build/filename_rules.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
bulach
lgtm, thanks!
7 years, 5 months ago (2013-07-22 11:21:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19685007/2001
7 years, 5 months ago (2013-07-22 11:56:47 UTC) #2
commit-bot: I haz the power
7 years, 5 months ago (2013-07-22 16:07:52 UTC) #3
Message was sent while issue was closed.
Change committed as 212890

Powered by Google App Engine
This is Rietveld 408576698