Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2715)

Unified Diff: content/renderer/browser_plugin/browser_plugin_bindings.cc

Issue 19679002: <webview>: Implement dialog API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin_bindings.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_bindings.cc b/content/renderer/browser_plugin/browser_plugin_bindings.cc
index fb40d00fe2f873ecf46783cc1aa61653bb545e31..13052c29150239c95d92bd8b65a2726d7d9b22b6 100644
--- a/content/renderer/browser_plugin/browser_plugin_bindings.cc
+++ b/content/renderer/browser_plugin/browser_plugin_bindings.cc
@@ -353,7 +353,7 @@ class BrowserPluginBindingSetPermission : public BrowserPluginMethodBinding {
public:
BrowserPluginBindingSetPermission()
: BrowserPluginMethodBinding(
- browser_plugin::kMethodInternalSetPermission, 2) {
+ browser_plugin::kMethodInternalSetPermission, 3) {
}
virtual bool Invoke(BrowserPluginBindings* bindings,
@@ -361,7 +361,9 @@ class BrowserPluginBindingSetPermission : public BrowserPluginMethodBinding {
NPVariant* result) OVERRIDE {
int request_id = IntFromNPVariant(args[0]);
bool allow = NPVARIANT_TO_BOOLEAN(args[1]);
- bindings->instance()->OnEmbedderDecidedPermission(request_id, allow);
+ std::string user_input = StringFromNPVariant(args[2]);
+ bindings->instance()->OnEmbedderDecidedPermission(
+ request_id, allow, user_input);
return true;
}
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698