Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: content/common/browser_plugin/browser_plugin_messages.h

Issue 19679002: <webview>: Implement dialog API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/browser_plugin/browser_plugin_messages.h
diff --git a/content/common/browser_plugin/browser_plugin_messages.h b/content/common/browser_plugin/browser_plugin_messages.h
index b3d5669ebad95531fecb1cd522cd7c333ef0a70c..a91f92fb8c647d6895a3af91ec0b39bb7b5691ff 100644
--- a/content/common/browser_plugin/browser_plugin_messages.h
+++ b/content/common/browser_plugin/browser_plugin_messages.h
@@ -253,11 +253,13 @@ IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_SetName,
// Note that |allow| = true does not readily mean that the guest will be granted
// permission, since a security check in the embedder might follow. For example
// for media access permission, the guest will be granted permission only if its
-// embedder also has access.
-IPC_MESSAGE_ROUTED3(BrowserPluginHostMsg_RespondPermission,
+// embedder also has access. For certain APIs, such as the Dialog API,
+// additional information may be passed by the developer through |user_input|.
+IPC_MESSAGE_ROUTED4(BrowserPluginHostMsg_RespondPermission,
int /* instance_id */,
int /* request_id */,
- bool /* allow */)
+ bool /* allow */,
+ std::string /* user_input */)
// Sends a PointerLock Lock ACK to the BrowserPluginGuest.
IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_LockMouse_ACK,
« no previous file with comments | « content/common/browser_plugin/browser_plugin_message_enums.h ('k') | content/renderer/browser_plugin/browser_plugin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698