chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 196783002: Export a private webstore API to call into the new inline sign-in flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 196783002: Export a private webstore API to call into the new inline sign-in flow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Redirect to the continue URL when Sync is disabled Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/sync/one_click_signin_sync_observer.cc ('K') | « chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | chrome/common/extensions/api/webstore_private.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index 0d2e2ad6d3303ec3bb5fd64ea5953608eee55156..9d180ec46ec70d874fede423d9b11171d99b87ed 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -149,12 +149,20 @@ void InlineSigninHelper::OnSigninOAuthInformationAvailable(

if (start_signin) {

// Call OneClickSigninSyncStarter to exchange oauth code for tokens.

// OneClickSigninSyncStarter will delete itself once the job is done.

+ std::string continue_url_str;

+ net::GetValueForKeyInQuery(current_url_, "continueUrl",

+ &continue_url_str);

+ GURL continue_url = GURL(continue_url_str);

+ if (!continue_url.is_valid())

+ continue_url = GURL();

new OneClickSigninSyncStarter(

profile_, browser,

email, password_, refresh_token,

start_mode,

contents,

confirmation_required,

+ continue_url,

base::Bind(&InlineLoginHandlerImpl::SyncStarterCallback, handler_));

}