Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 19672022: [SystemInfo API] Update systemInfo.storage API StorageUnitInfo Definition. (Closed)

Created:
7 years, 5 months ago by Haojian Wu
Modified:
7 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Jeffrey Yasskin, Greg Billock
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[SystemInfo API] Update systemInfo.storage API StorageUnitInfo Definition. Remove |available_capacity| field. BUG=252994 TEST=browser_tests --gtest_fitler=SystemInfoStorageApiTest.* TEST=unit_tests --gtest_filter=StorageInfoProviderTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213368

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -44 lines) Patch
M chrome/browser/extensions/api/system_info/system_info_api.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/common/extensions/api/experimental_system_info_storage.idl View 1 chunk +0 lines, -3 lines 1 comment Download
M chrome/test/data/extensions/api_test/systeminfo/storage/test_storage_api.js View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Haojian Wu
A new separated CL from the storage API renamed CL https://chromiumcodereview.appspot.com/18578008/. Please have a review. ...
7 years, 5 months ago (2013-07-23 03:17:26 UTC) #1
not at google - send to devlin
lgtm but what is the reason for this change? The BUG is just some generic ...
7 years, 5 months ago (2013-07-23 15:39:43 UTC) #2
Hongbo Min
On 2013/07/23 15:39:43, kalman wrote: > lgtm but what is the reason for this change? ...
7 years, 5 months ago (2013-07-24 00:10:40 UTC) #3
not at google - send to devlin
yes thanks. Perhaps file a bug and link to it in the future.
7 years, 5 months ago (2013-07-24 00:12:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/19672022/1
7 years, 5 months ago (2013-07-24 01:03:54 UTC) #5
commit-bot: I haz the power
Change committed as 213368
7 years, 5 months ago (2013-07-24 07:30:29 UTC) #6
not at google - send to devlin
7 years, 5 months ago (2013-07-25 14:34:01 UTC) #7
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/19672022/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/experimental_system_info_storage.idl (right):

https://chromiumcodereview.appspot.com/19672022/diff/1/chrome/common/extensio...
chrome/common/extensions/api/experimental_system_info_storage.idl:93: static
void onAvailableCapacityChanged(StorageFreeSpaceChangeInfo info);
what about this event?

Powered by Google App Engine
This is Rietveld 408576698