gclient.py - Issue 19670012: Check to see if a dependency was skipped in custom_deps, and if so, skip it in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 19670012: Check to see if a dependency was skipped in custom_deps, and if so, skip it in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient.py

diff --git a/gclient.py b/gclient.py

index ed08e47f423cb96bbd6ba9c9ca2902cbc394cc62..789d89b9dd78c5603f0597ab1babdb12ce406009 100755

--- a/gclient.py

+++ b/gclient.py

@@ -705,7 +705,9 @@ class Dependency(gclient_utils.WorkItem, DependencySettings):

print_stdout = True

filter_fn = None

- if os.path.isdir(cwd):

+ if parsed_url is None:

+ print >> sys.stderr, 'Skipped omitted dependency %s' % cwd

+ elif os.path.isdir(cwd):

M-A Ruel 2013/07/18 15:11:43 Shouldn't this check be sufficient? I mean if the

try:

gclient_utils.CheckCallAndFilter(

args, cwd=cwd, env=env, print_stdout=print_stdout,

« no previous file with comments | « no previous file | no next file » | no next file with comments »