Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 19670004: Refactor build/android/symbolize.py to function as an output filter. (Closed)

Created:
7 years, 5 months ago by scherkus (not reviewing)
Modified:
7 years, 5 months ago
Reviewers:
bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Refactor build/android/symbolize.py to function as an output filter. Doing so will make it easy to drop in as a test logfile text filter, similar to android_commands.NewLineNormalizer. BUG=261311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212438

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M build/android/symbolize.py View 2 chunks +25 lines, -21 lines 2 comments Download
M build/android/symbolize_test.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scherkus (not reviewing)
care to review, bulach? https://codereview.chromium.org/19675003/ is the follow up CL, but I want to land ...
7 years, 5 months ago (2013-07-17 20:39:17 UTC) #1
bulach
lgtm, small suggestion below: https://codereview.chromium.org/19670004/diff/3001/build/android/symbolize.py File build/android/symbolize.py (right): https://codereview.chromium.org/19670004/diff/3001/build/android/symbolize.py#newcode34 build/android/symbolize.py:34: def write(self, data): nit: it ...
7 years, 5 months ago (2013-07-18 09:07:02 UTC) #2
scherkus (not reviewing)
thanks for the review! https://codereview.chromium.org/19670004/diff/3001/build/android/symbolize.py File build/android/symbolize.py (right): https://codereview.chromium.org/19670004/diff/3001/build/android/symbolize.py#newcode34 build/android/symbolize.py:34: def write(self, data): On 2013/07/18 ...
7 years, 5 months ago (2013-07-18 18:08:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/19670004/3001
7 years, 5 months ago (2013-07-18 18:09:19 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 21:37:46 UTC) #5
Message was sent while issue was closed.
Change committed as 212438

Powered by Google App Engine
This is Rietveld 408576698