Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 19668008: cc: Remove some DCHECKs in CopyOutputRequest code. (Closed)

Created:
7 years, 5 months ago by danakj
Modified:
7 years, 5 months ago
Reviewers:
enne (OOO), piman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Remove some DCHECKs in CopyOutputRequest code. These DCHECKs fire if we ever commit to the impl side twice without performing a draw in between. There are various ways that this could happen, and it doesn't really matter to the CopyOutputRequest code anyways, so remove the DCHECKs and deal with the case gracefully instead. Test: LayerTreeHostTestAsyncTwoReadbacksWithoutDraw BUG=263486 R=enne,piman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213270

Patch Set 1 #

Patch Set 2 : readback-bad-dchecks: add test #

Patch Set 3 : readback-bad-dchecks: better test #

Patch Set 4 : readback-bad-dchecks: threadsafe test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
M cc/layers/layer_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
danakj
7 years, 5 months ago (2013-07-23 18:31:24 UTC) #1
enne (OOO)
Is it easy to modify one of your existing unit tests to exercise this?
7 years, 5 months ago (2013-07-23 18:33:36 UTC) #2
piman
lgtm
7 years, 5 months ago (2013-07-23 18:34:05 UTC) #3
danakj
On 2013/07/23 18:33:36, enne wrote: > Is it easy to modify one of your existing ...
7 years, 5 months ago (2013-07-23 18:35:42 UTC) #4
danakj
Test added LayerTreeHostTestAsyncTwoReadbacksWithoutDraw
7 years, 5 months ago (2013-07-23 18:59:45 UTC) #5
enne (OOO)
lgtm, thanks!
7 years, 5 months ago (2013-07-23 19:00:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/19668008/13001
7 years, 5 months ago (2013-07-23 19:06:29 UTC) #7
commit-bot: I haz the power
Failed to trigger a try job on chromium_presubmit HTTP Error 400: Bad Request
7 years, 5 months ago (2013-07-23 19:06:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/19668008/18001
7 years, 5 months ago (2013-07-23 19:09:10 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 23:30:13 UTC) #10
Message was sent while issue was closed.
Change committed as 213270

Powered by Google App Engine
This is Rietveld 408576698