Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 19668002: [PDF] Use SkTypeface::countGlyphs instead of getAdvancedTypefaceMetrics (Closed)

Created:
7 years, 5 months ago by vandebo (ex-Chrome)
Modified:
7 years, 5 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

[PDF] Use SkTypeface::countGlyphs instead of getAdvancedTypefaceMetrics resubmit r10063 BUG=1088 Committed: http://code.google.com/p/skia/source/detail?r=10133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M src/pdf/SkPDFDevice.cpp View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vandebo (ex-Chrome)
7 years, 5 months ago (2013-07-17 19:29:00 UTC) #1
bungeman-skia
lgtm, hopefully this time it's actually implemented everywhere.
7 years, 5 months ago (2013-07-17 20:21:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/19668002/1
7 years, 5 months ago (2013-07-17 20:22:34 UTC) #3
reed1
we could change the base class to = 0, so the linker will tell us ...
7 years, 5 months ago (2013-07-17 20:56:39 UTC) #4
commit-bot: I haz the power
List of reviewers changed. reed@google.com did a drive-by without LGTM'ing!
7 years, 5 months ago (2013-07-17 21:49:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/19668002/1
7 years, 5 months ago (2013-07-17 21:55:02 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 21:55:09 UTC) #7
Message was sent while issue was closed.
Change committed as 10133

Powered by Google App Engine
This is Rietveld 408576698