Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 19666007: Merge 212122 "net: allow fallback down to TLS 1.0 in the event o..." (Closed)

Created:
7 years, 5 months ago by agl
Modified:
7 years, 5 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Merge 212122 "net: allow fallback down to TLS 1.0 in the event o..." > net: allow fallback down to TLS 1.0 in the event of a bad-record-MAC alert. > > TLS 1.1 support has uncovered several examples of a new kind of broken server: > they negotiate TLS 1.0 correctly in the face of a 1.1 or 1.2 ClientHello, but > then fail with a bad-record-MAC alert when processing the client's Finished > message. > > This bug is exhibited by at least two different types of SSL "accelerator" > device, which will probably take forever to be fixed. So, with a heavy heart, > this change adds yet another workaround. > > BUG=260358 > R=rsleevi@chromium.org > > Review URL: https://codereview.chromium.org/19607008 TBR=agl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M net/socket/ssl_client_socket_nss.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
agl
7 years, 5 months ago (2013-07-23 16:16:51 UTC) #1
agl
7 years, 5 months ago (2013-07-23 16:17:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r213136.

Powered by Google App Engine
This is Rietveld 408576698