Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 19665003: Removes m17n:vi:vni as the chromeos-keyboards has replaced it. (Closed)

Created:
7 years, 5 months ago by Shu Chen
Modified:
7 years, 5 months ago
Reviewers:
zhangchi, Seigo Nonaka
CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removes m17n:vi:vni as the chromeos-keyboards has replaced it. BUG=chromium:240659 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/ime/input_methods.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Seigo Nonaka
lgtm FYI: just BUG=240659 is fine in the case of browse side code review :)
7 years, 5 months ago (2013-07-24 09:01:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/19665003/1
7 years, 5 months ago (2013-07-24 09:09:32 UTC) #2
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-24 09:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/19665003/1
7 years, 5 months ago (2013-07-24 11:50:31 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 16:08:03 UTC) #5
Message was sent while issue was closed.
Change committed as 213441

Powered by Google App Engine
This is Rietveld 408576698