Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 19663003: Remove unecessary malloc seen in http://sina.com.cn (#17) (Closed)

Created:
7 years, 5 months ago by eseidel
Modified:
7 years, 5 months ago
Reviewers:
tonyg, abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove unecessary malloc seen in http://sina.com.cn (#17) Content calls down into Blink a bunch of times during loading to check the document's encoding. Every time we were allocating a new copy of a constant string. The right fix is to fix TextEncoding to have fancier static-string technology, but this is the quick-fix to get this malloc off the profile of http://sina.com.cn. BUG=261689 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/dom/Document.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
eseidel
7 years, 5 months ago (2013-07-17 23:56:09 UTC) #1
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-17 23:57:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/19663003/1
7 years, 5 months ago (2013-07-17 23:58:21 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=17459
7 years, 5 months ago (2013-07-18 01:56:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/19663003/1
7 years, 5 months ago (2013-07-18 19:24:44 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 5 months ago (2013-07-18 19:40:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/19663003/1
7 years, 5 months ago (2013-07-18 19:47:58 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 19:48:13 UTC) #8
Message was sent while issue was closed.
Change committed as 154508

Powered by Google App Engine
This is Rietveld 408576698