runtime/vm/intrinsifier_ia32.cc - Issue 1965493004: Canonicalize generic types in an isolate specific hash table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 1965493004: Canonicalize generic types in an isolate specific hash table (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address-code-review-comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_ia32.cc

diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc

index 8dc9e999655f0977f31a7fe19dbdb8aa5b743961..006511e33270bdf15c8675891596c6fce20eba74 100644

--- a/runtime/vm/intrinsifier_ia32.cc

+++ b/runtime/vm/intrinsifier_ia32.cc

@@ -1697,7 +1697,7 @@ void Intrinsifier::ObjectRuntimeType(Assembler* assembler) {

__ movzxw(EDI, FieldAddress(EBX, Class::num_type_arguments_offset()));

__ cmpl(EDI, Immediate(0));

__ j(NOT_EQUAL, &fall_through, Assembler::kNearJump);

- __ movl(EAX, FieldAddress(EBX, Class::canonical_types_offset()));

+ __ movl(EAX, FieldAddress(EBX, Class::canonical_type_offset()));

__ CompareObject(EAX, Object::null_object());

__ j(EQUAL, &fall_through, Assembler::kNearJump); // Not yet set.

__ ret();