runtime/vm/intrinsifier_arm.cc - Issue 1965493004: Canonicalize generic types in an isolate specific hash table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 1965493004: Canonicalize generic types in an isolate specific hash table (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address-code-review-comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_arm.cc

diff --git a/runtime/vm/intrinsifier_arm.cc b/runtime/vm/intrinsifier_arm.cc

index e878d033bdc1b7c73d269f0bc34330f742dae26c..2d2f724cdfc2b1a76618e0f7f42b2a9d82d789fe 100644

--- a/runtime/vm/intrinsifier_arm.cc

+++ b/runtime/vm/intrinsifier_arm.cc

@@ -1557,7 +1557,7 @@ void Intrinsifier::ObjectRuntimeType(Assembler* assembler) {

__ CompareImmediate(R3, 0);

__ b(&fall_through, NE);

- __ ldr(R0, FieldAddress(R2, Class::canonical_types_offset()));

+ __ ldr(R0, FieldAddress(R2, Class::canonical_type_offset()));

__ CompareObject(R0, Object::null_object());

__ b(&fall_through, EQ);

__ Ret();

« no previous file with comments | « no previous file | runtime/vm/intrinsifier_arm64.cc » ('j') | runtime/vm/object.cc » ('J')