Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 19649007: Update the WebMediaSourceClientImpl & ChunkDemuxer to received explicit end of stream cancellation. (Closed)

Created:
7 years, 5 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Update the WebMediaSourceClientImpl & ChunkDemuxer to received explicit end of stream cancellation. There are other MediaSource API interactions other than append() that can cause a transition out of the "end of stream" state. This patch simply makes it possible for ChunkDemuxer to get explicitly notified by Blink when entering/leaving the "end of stream" state. BUG=239506 TEST=All existing tests pass. Additional LayoutTests will be added to cover non-append related transitions out of the "end of stream" state. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212753

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix build buster caused by rebase. #

Total comments: 4

Patch Set 4 : Address CR comments. #

Patch Set 5 : Make chromium style enforcers happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -57 lines) Patch
M content/renderer/media/webmediasourceclient_impl.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/media/webmediasourceclient_impl.cc View 1 2 3 4 2 chunks +11 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer.h View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 2 6 chunks +25 lines, -20 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 22 chunks +31 lines, -25 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/source_buffer_stream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
acolwell GONE FROM CHROMIUM
7 years, 5 months ago (2013-07-19 20:13:42 UTC) #1
acolwell GONE FROM CHROMIUM
7 years, 5 months ago (2013-07-19 20:21:49 UTC) #2
acolwell GONE FROM CHROMIUM
FYI. The mark/unmark convention came from abarth@ on the Blink-side changes. I'm just propagating them ...
7 years, 5 months ago (2013-07-19 20:27:08 UTC) #3
scherkus (not reviewing)
is it legal to call unmark if it hasn't been marked? https://codereview.chromium.org/19649007/diff/15001/content/renderer/media/webmediasourceclient_impl.cc File content/renderer/media/webmediasourceclient_impl.cc (right): ...
7 years, 5 months ago (2013-07-19 20:35:47 UTC) #4
acolwell GONE FROM CHROMIUM
On 2013/07/19 20:35:47, scherkus wrote: > is it legal to call unmark if it hasn't ...
7 years, 5 months ago (2013-07-19 20:45:54 UTC) #5
scherkus (not reviewing)
lgtm
7 years, 5 months ago (2013-07-19 21:23:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/19649007/21001
7 years, 5 months ago (2013-07-19 21:28:16 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-19 21:50:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/19649007/36001
7 years, 5 months ago (2013-07-19 22:21:11 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-19 22:36:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/19649007/36001
7 years, 5 months ago (2013-07-19 23:14:55 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-20 05:48:08 UTC) #12
Message was sent while issue was closed.
Change committed as 212753

Powered by Google App Engine
This is Rietveld 408576698