Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 19641009: drive: Add test for ChangeListLoader::LoadIfNeeded with non empty DirectoryFetchInfo (Closed)

Created:
7 years, 5 months ago by hashimoto
Modified:
7 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Add test for ChangeListLoader::LoadIfNeeded with non empty DirectoryFetchInfo Introduce TestDriveService to emulate the slowness of GetAllResourceList(). BUG=161703 TEST=unit_tests --gtest_filter="ChangeListLoaderTest.LoadIfNeeded_WithDirectoryFetchInfo" R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213746

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix int type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -2 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 1 4 chunks +111 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
7 years, 5 months ago (2013-07-24 09:08:54 UTC) #1
kinaba
lgtm https://codereview.chromium.org/19641009/diff/7001/chrome/browser/chromeos/drive/change_list_loader_unittest.cc File chrome/browser/chromeos/drive/change_list_loader_unittest.cc (right): https://codereview.chromium.org/19641009/diff/7001/chrome/browser/chromeos/drive/change_list_loader_unittest.cc#newcode276 chrome/browser/chromeos/drive/change_list_loader_unittest.cc:276: const int mydrive_changestamp = entry.directory_specific_info().changestamp(); changestamp should be ...
7 years, 5 months ago (2013-07-25 08:48:39 UTC) #2
hashimoto
https://codereview.chromium.org/19641009/diff/7001/chrome/browser/chromeos/drive/change_list_loader_unittest.cc File chrome/browser/chromeos/drive/change_list_loader_unittest.cc (right): https://codereview.chromium.org/19641009/diff/7001/chrome/browser/chromeos/drive/change_list_loader_unittest.cc#newcode276 chrome/browser/chromeos/drive/change_list_loader_unittest.cc:276: const int mydrive_changestamp = entry.directory_specific_info().changestamp(); On 2013/07/25 08:48:39, kinaba ...
7 years, 5 months ago (2013-07-25 09:32:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/19641009/15001
7 years, 5 months ago (2013-07-25 16:34:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/19641009/15001
7 years, 5 months ago (2013-07-26 00:29:28 UTC) #5
hashimoto
7 years, 5 months ago (2013-07-26 03:07:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r213746 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698