Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 19641006: Cancel vibration when frame load is committed. (Closed)

Created:
7 years, 5 months ago by Michael van Ouwerkerk
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cancel vibration when frame load is committed. We currently don't handle subframes in a beautiful way, vibrations initiated in one frame may be cancelled from another frame. The expected behavior is not currently defined in the specification but we have started that discussion: http://lists.w3.org/Archives/Public/public-device-apis/2013Jul/0031.html BUG=222504 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/Page.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/page/PageLifecycleNotifier.h View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/page/PageLifecycleObserver.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/vibration/NavigatorVibration.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/vibration/NavigatorVibration.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael van Ouwerkerk
Hi Adam, this is a replacement for this patch: https://codereview.chromium.org/19757009/ Sorry for starting another patch, ...
7 years, 5 months ago (2013-07-22 11:32:51 UTC) #1
abarth-chromium
On 2013/07/22 11:32:51, Michael van Ouwerkerk wrote: > Sorry for starting another patch, I set ...
7 years, 5 months ago (2013-07-22 18:00:32 UTC) #2
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-22 18:01:54 UTC) #3
abarth-chromium
It would have been better to have a test, but I understand the difficulties you ...
7 years, 5 months ago (2013-07-22 18:02:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/19641006/1
7 years, 5 months ago (2013-07-22 18:02:25 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-22 19:25:10 UTC) #6
Message was sent while issue was closed.
Change committed as 154674

Powered by Google App Engine
This is Rietveld 408576698