Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19638008: Refactor GpuVideoDecoder::Factories out of GpuVideoDecoder. (Closed)

Created:
7 years, 5 months ago by wuchengli
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, Ami GONE FROM CHROMIUM
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refactor GpuVideoDecoder::Factories out of GpuVideoDecoder. GpuVideoDecoder::Factories is used by GpuVideoDecoder and RTCVideoDecoder. Move it to a new file. BUG=170345 TEST=Run http://apprtc.appspot.com/?debug=loopback on chromebook daisy. Play hardware-accelerated videos. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213367

Patch Set 1 : #

Total comments: 16

Patch Set 2 : use forward declaration and address review comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -105 lines) Patch
M content/renderer/media/media_stream_dependency_factory.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_decoder_factories.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.h View 1 2 6 chunks +11 lines, -11 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_video_decoder_factory.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_decoder_factory.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_params.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/webmediaplayer_params.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 3 chunks +3 lines, -44 lines 0 comments Download
media/filters/gpu_video_decoder.cc View 1 2 4 chunks +21 lines, -19 lines 0 comments Download
A media/filters/gpu_video_decoder_factories.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A + media/filters/gpu_video_decoder_factories.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/mock_gpu_video_decoder_factories.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/media.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
wuchengli
Please take a look.
7 years, 5 months ago (2013-07-19 07:38:37 UTC) #1
wuchengli
Please take a look.
7 years, 5 months ago (2013-07-19 07:38:38 UTC) #2
wuchengli
This refactor address one of the review comments in https://codereview.chromium.org/19534002/ scherkus@ the refactor piman@ OWNERS ...
7 years, 5 months ago (2013-07-19 07:43:18 UTC) #3
Ami GONE FROM CHROMIUM
LGTM
7 years, 5 months ago (2013-07-19 07:58:25 UTC) #4
piman
lgtm
7 years, 5 months ago (2013-07-19 17:41:20 UTC) #5
scherkus (not reviewing)
https://codereview.chromium.org/19638008/diff/5001/content/renderer/media/rtc_video_decoder.h File content/renderer/media/rtc_video_decoder.h (right): https://codereview.chromium.org/19638008/diff/5001/content/renderer/media/rtc_video_decoder.h#newcode23 content/renderer/media/rtc_video_decoder.h:23: #include "media/filters/gpu_video_decoder_factories.h" you might be able to fwd decl ...
7 years, 5 months ago (2013-07-19 18:00:53 UTC) #6
wuchengli
All done. PTAL. https://codereview.chromium.org/19638008/diff/5001/content/renderer/media/rtc_video_decoder.h File content/renderer/media/rtc_video_decoder.h (right): https://codereview.chromium.org/19638008/diff/5001/content/renderer/media/rtc_video_decoder.h#newcode23 content/renderer/media/rtc_video_decoder.h:23: #include "media/filters/gpu_video_decoder_factories.h" On 2013/07/19 18:00:54, scherkus ...
7 years, 5 months ago (2013-07-20 03:15:46 UTC) #7
scherkus (not reviewing)
lgtm
7 years, 5 months ago (2013-07-22 17:48:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/19638008/24001
7 years, 5 months ago (2013-07-23 01:51:41 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=150916
7 years, 5 months ago (2013-07-23 03:20:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/19638008/68001
7 years, 5 months ago (2013-07-23 03:48:25 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=150993
7 years, 5 months ago (2013-07-23 05:13:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/19638008/68001
7 years, 5 months ago (2013-07-23 06:23:28 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=151051
7 years, 5 months ago (2013-07-23 07:01:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/19638008/68001
7 years, 5 months ago (2013-07-24 03:55:55 UTC) #15
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 07:30:07 UTC) #16
Message was sent while issue was closed. 
Change committed as 213367

Powered by Google App Engine
This is Rietveld 408576698