Set argv[0] of the buildbot master process to the name of the master.

Set argv[0] of the buildbot master process to the name of the master.

BUG=609995
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300520

[dsansome, 2016-05-09 08:26:30]

Description was changed from

==========
Set argv[0] of the buildbot master process to the name of the master.

BUG=
==========

to

==========
Set argv[0] of the buildbot master process to the name of the master.

BUG=609995
==========

[dsansome, 2016-05-09 08:26:50]

dsansome@chromium.org changed reviewers:
+ friedman@chromium.org

[dsansome, 2016-05-09 08:26:51]

This is much cooler than using absolute paths. http://i.imgur.com/vgVWcfO.png

[friedman1, 2016-05-09 17:28:50]

On 2016/05/09 08:26:51, dsansome wrote:
> This is much cooler than using absolute paths. http://i.imgur.com/vgVWcfO.png

This looks to be equal parts black magic and awesome...  I'm adding some more
relevant people to the review list just to be safe :)  Thanks for this...
interesting to know about for sure.

[friedman1, 2016-05-09 17:29:15]

friedman@google.com changed reviewers:
+ iannucci@chromium.org

[iannucci, 2016-05-09 23:29:01]

I'm sure this will break something horribly, so please try this out on just the
*infra* waterfalls for a day or two. Other than that, lgtm.

[dsansome, 2016-05-10 08:05:17]

On 2016/05/09 23:29:01, iannucci wrote:
> I'm sure this will break something horribly, so please try this out on just
the
> *infra* waterfalls for a day or two. Other than that, lgtm.

Good thinking.  I've added a check to the code that will only enable it on
chromium.infra and chromium.infra.cron (so it doesn't get picked up if someone
restarts some other masters for another reason).

[dsansome, 2016-05-10 08:05:21]

The CQ bit was checked by dsansome@chromium.org

[dsansome, 2016-05-10 08:05:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1963583002/#ps20001
(title: "Only enable on two infra masters")

[commit-bot: I haz the power, 2016-05-10 08:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963583002/20001

[commit-bot: I haz the power, 2016-05-10 08:10:09]

Description was changed from

==========
Set argv[0] of the buildbot master process to the name of the master.

BUG=609995
==========

to

==========
Set argv[0] of the buildbot master process to the name of the master.

BUG=609995

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300520
==========

[commit-bot: I haz the power, 2016-05-10 08:10:10]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300520

[dnj (Google), 2016-05-10 16:32:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1959063004/ by dnj@google.com.

The reason for reverting is: This causes all "chromium.infra" and
"chromium.infra.cron" builds to fail because we are "sys.exit(2)" on non-Linux
platforms. This can't be what you meant to do..

[iannucci, 2016-05-10 16:33:45]

*sigh* I should have caught that

On Tue, May 10, 2016, 09:32 <dnj@google.com> wrote:

> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1959063004/ by dnj@google.com.
>
> The reason for reverting is: This causes all "chromium.infra" and
> "chromium.infra.cron" builds to fail because we are "sys.exit(2)" on
> non-Linux
> platforms. This can't be what you meant to do..
>
> https://codereview.chromium.org/1963583002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dsansome, 2016-05-19 14:48:40]

On 2016/05/10 16:33:45, iannucci wrote:
> *sigh* I should have caught that
> 
> On Tue, May 10, 2016, 09:32 <mailto:dnj@google.com> wrote:
> 
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/1959063004/ by mailto:dnj@google.com.
> >
> > The reason for reverting is: This causes all "chromium.infra" and
> > "chromium.infra.cron" builds to fail because we are "sys.exit(2)" on
> > non-Linux
> > platforms. This can't be what you meant to do..
> >
> > https://codereview.chromium.org/1963583002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Oh crap.  I put that in for testing and forgot to remove it.  *I* should have
caught that.  Sorry.
I'll fix it and send another CL.