Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19631004: Update include paths in chrome/browser/ for base/process changes. (Closed)

Created:
7 years, 5 months ago by Robert Sesek
Modified:
7 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, vandebo (ex-Chrome), skanuj+watch_chromium.org, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, yoshiki+watch_chromium.org, stuartmorgan+watch_chromium.org, native-client-reviews_googlegroups.com, Ilya Sherman, yusukes+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, jar (doing other things), nona+watch_chromium.org, stevenjb+watch_chromium.org, jam, dominich, marja+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, David Black, samarth+watch_chromium.org, mad+watch_chromium.org, haitaol+watch_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, asvitkine+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org, oshima+watch_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, tommycli, robertshield, Greg Billock, kmadhusu+watch_chromium.org, rsimha+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Update include paths in chrome/browser/ for base/process changes. BUG=242290 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213461

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Patch Set 3 : Compile fixes #

Patch Set 4 : Merge ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -121 lines) Patch
M chrome/browser/android/crash_dump_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/crash_dump_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_about_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_platform_part_aurawin.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chrome_main_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_process_finder_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system_logs/command_line_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_patcher_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/record/record_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_url_rewrite_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extensions_quota_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/gtalk_extension_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/first_run/first_run_internal_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/importer/firefox_profile_lock_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/mac/relauncher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/perf_provider_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/tracking_synchronizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/test/mock_nacl_gdb.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/page_cycler/page_cycler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printer_manager_dialog_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/process_info_snapshot.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/process_info_snapshot_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/process_info_snapshot_mac_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_linux_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/web_cache_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/service/service_process_control.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_manager/browser_process_resource_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/os_resource_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/resource_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/hung_plugin_tab_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sad_tab.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_ntp.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_renderer_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/unload_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_data_dir_extractor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_data_dir_extractor_win_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Robert Sesek
I split this up by second-level directories and it's still huge :'(.
7 years, 5 months ago (2013-07-22 20:54:31 UTC) #1
Nico
stampy lgtm. please address comments 2 and 3; 1 is optional. (if (2) was caused ...
7 years, 5 months ago (2013-07-22 21:02:02 UTC) #2
Robert Sesek
https://codereview.chromium.org/19631004/diff/1/chrome/browser/extensions/api/messaging/native_process_launcher.h File chrome/browser/extensions/api/messaging/native_process_launcher.h (right): https://codereview.chromium.org/19631004/diff/1/chrome/browser/extensions/api/messaging/native_process_launcher.h#newcode11 chrome/browser/extensions/api/messaging/native_process_launcher.h:11: #include "base/process/process.h" On 2013/07/22 21:02:02, Nico wrote: > Huh, ...
7 years, 5 months ago (2013-07-22 21:17:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/19631004/7001
7 years, 5 months ago (2013-07-22 21:58:42 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-22 22:43:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/19631004/29001
7 years, 5 months ago (2013-07-23 17:05:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, nacl_integration, ...
7 years, 5 months ago (2013-07-23 21:50:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/19631004/44001
7 years, 5 months ago (2013-07-24 15:11:28 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 17:37:06 UTC) #9
Message was sent while issue was closed. 
Change committed as 213461

Powered by Google App Engine
This is Rietveld 408576698