Chromium Code Reviews
DescriptionRevert of [Chrome Settings UI] If User Exceptions are not allowed, prevent editing / viewing. (patchset #9 id:160001 of https://chromiumcodereview.appspot.com/1855393006/ )
Reason for revert:
Reverting since this is causing http://crbug.com/609725 . Problem is that we're hiding all "non-editable" entries in exception lists. However, the list is sometimes used for read-only data, e.g., Zoom Level. Will need to modify the logic in a follow-up.
Original issue's description:
> [Chrome Settings UI] If User Exceptions are not allowed, prevent editing / viewing.
>
> If user exceptions are rendered useless by policy defaults (or other default
> providers with higher precedence), disabled them in exceptions dialog by:
> - Hiding all editable rows.
> - Removing the "Add New Exceptions" row.
>
> BUG=568031
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/ff30d12673cee058e00d6d8da59ba971f24172bb
> Cr-Commit-Position: refs/heads/master@{#391885}
TBR=estade@chromium.org,dbeam@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=568031
Committed: https://crrev.com/e6bf538f47aae111b57f425071c48163c1f28795
Cr-Commit-Position: refs/heads/master@{#392453}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||