Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: Source/bindings/scripts/idl_compiler.py

Issue 19607011: Generate binding code for VoidCallback.idl with code generator in python (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: nits Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.py ('k') | Source/bindings/templates/callback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/idl_compiler.py
diff --git a/Source/bindings/scripts/idl_compiler.py b/Source/bindings/scripts/idl_compiler.py
index e47843d2f55d9bf2c3e9770eee52d1829de01ec2..6486ebe5fcd242582b27060b7977330ff144996b 100755
--- a/Source/bindings/scripts/idl_compiler.py
+++ b/Source/bindings/scripts/idl_compiler.py
@@ -104,20 +104,16 @@ def main():
reader = idl_reader.IdlReader(options.interface_dependencies_file, options.additional_idl_files, options.idl_attributes_file, output_directory, verbose)
definitions = reader.read_idl_definitions(idl_filename)
+ code_generator = code_generator_v8.CodeGeneratorV8(definitions, interface_name, options.output_directory, options.idl_directories, verbose)
if not definitions:
# We generate dummy .h and .cpp files just to tell build scripts
# that outputs have been created.
- code_generator_v8.generate_dummy_header_and_cpp(interface_name, output_directory)
+ code_generator.write_dummy_header_and_cpp()
return
if options.dump_json_and_pickle:
write_json_and_pickle(definitions, interface_name, output_directory)
return
- # FIXME: turn on code generator
- # Currently definitions must be None (so dummy .h and .cpp files are
- # generated), or --dump-json-and-pickle selected, as actual code generator
- # not present yet.
- # code_generator_v8.write_interface(definitions, interface_name, options.output_directory)
- raise RuntimeError('Stub: code generator not implemented yet')
+ code_generator.write_header_and_cpp()
if __name__ == '__main__':
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.py ('k') | Source/bindings/templates/callback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698