Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 19602003: Use a direct include of the message_loop header in chrome/browser/, part 7. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), jar (doing other things), Lei Zhang, tfarina, asvitkine+watch_chromium.org, tommycli, pam+watch_chromium.org, Greg Billock, tzik+watch_chromium.org, kinuko+watch, native-client-reviews_googlegroups.com, Ilya Sherman
Visibility:
Public.

Description

Use a direct include of the message_loop header in chrome/browser/, part 7. BUG=260807 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212332

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M chrome/browser/external_protocol/external_protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/icon_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/profile_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/internal_auth_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/invalidator_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jankometer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_url_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_refresh_token_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_registration_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_finder_win_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_request_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/balloon_collection_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_cycler/page_cycler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19602003/1
7 years, 5 months ago (2013-07-17 15:12:50 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=176932
7 years, 5 months ago (2013-07-17 23:54:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19602003/1
7 years, 5 months ago (2013-07-18 01:39:37 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/managed_mode/managed_mode_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 5 months ago (2013-07-18 01:39:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19602003/21001
7 years, 5 months ago (2013-07-18 01:44:44 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 12:07:21 UTC) #6
Message was sent while issue was closed.
Change committed as 212332

Powered by Google App Engine
This is Rietveld 408576698