Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issue 19597010: [telemetry] Define benchmark page sets in relation to base directory. (Closed)

Created:
7 years, 5 months ago by dtu
Modified:
7 years, 5 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Define benchmark page sets in relation to base directory. If you ran run_benchmark from different directories, it would be unable to find the page set. BUG=263511 TEST=None. R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M tools/telemetry/telemetry/test.py View 2 chunks +12 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/test_runner.py View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dtu
7 years, 5 months ago (2013-07-24 01:02:49 UTC) #1
tonyg
lgtm
7 years, 5 months ago (2013-07-24 01:05:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/19597010/1
7 years, 5 months ago (2013-07-24 01:09:19 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 05:17:32 UTC) #4
Message was sent while issue was closed.
Change committed as 213352

Powered by Google App Engine
This is Rietveld 408576698