Issue 19597006: Style cleanup: Rename callback -> onDone in chromoting webapp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19597006: Style cleanup: Rename callback -> onDone in chromoting webapp. (Closed)

Created:
7 years, 5 months ago by Lambros

Modified:
7 years, 5 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Style cleanup: Rename callback -> onDone in chromoting webapp. This makes host_dispatcher.js and host_native_messaging.js consistent with the rest of the webapp. Also fix function declaration style. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213311

Patch Set 1 #

Patch Set 2 : Fix function declaration style/indentation #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -122 lines)			Patch
	M	remoting/webapp/host_dispatcher.js	View	1	14 chunks	+61 lines, -66 lines	0 comments	Download
	M	remoting/webapp/host_native_messaging.js	View	1	20 chunks	+54 lines, -56 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/19597006/4001

7 years, 5 months ago (2013-07-23 23:11:25 UTC) #3

Message was sent while issue was closed.

Change committed as 213311

Expand Messages | Collapse Messages