Issue 19594009: chromeos: Update comment for ClosePanelsOnExtensionCrash.

Issue 19594009: chromeos: Update comment for ClosePanelsOnExtensionCrash. (Closed)

Created:
7 years, 5 months ago by Daniel Erat

Modified:
7 years, 5 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Update comment for ClosePanelsOnExtensionCrash. This updates the comment regarding WindowOpenPanelTest.ClosePanelsOnExtensionCrash being disabled on Chrome OS. I don't have any plans to reenable this test, since it appears to be testing behavior that we don't use. BUG=161073 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213320

Patch Set 1 #

Total comments: 1

Patch Set 2 : get rid of MAYBE_ #

Patch Set 3 : #endif would help too #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	chrome/browser/extensions/window_open_apitest.cc	View	1 2	2 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

https://codereview.chromium.org/19594009/diff/1/chrome/browser/extensions/window_open_apitest.cc File chrome/browser/extensions/window_open_apitest.cc (right): https://codereview.chromium.org/19594009/diff/1/chrome/browser/extensions/window_open_apitest.cc#newcode323 chrome/browser/extensions/window_open_apitest.cc:323: // crashed pages. Since this is the case, how ...

7 years, 5 months ago (2013-07-23 23:42:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/19594009/7001

7 years, 5 months ago (2013-07-24 00:12:26 UTC) #5

Message was sent while issue was closed.

Change committed as 213320

Expand Messages | Collapse Messages