Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 19593008: Use GetDisplayNearestWindow instead of GetDislpaymatching where appropriate (Closed)

Created:
7 years, 5 months ago by oshima
Modified:
7 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Use GetDisplayNearestWindow instead of GetDislpaymatching where appropriate This is correct way to tell on which display the window is on as a window doesn't overlap two displays on ash. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213347 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213788

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : win8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M ash/wm/drag_window_resizer.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/workspace/auto_window_management.cc View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
7 years, 5 months ago (2013-07-23 22:02:21 UTC) #1
sky
LGTM
7 years, 5 months ago (2013-07-23 22:44:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/19593008/10001
7 years, 5 months ago (2013-07-23 23:24:56 UTC) #3
commit-bot: I haz the power
Change committed as 213347
7 years, 5 months ago (2013-07-24 05:06:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/19593008/53001
7 years, 5 months ago (2013-07-25 01:56:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/19593008/53001
7 years, 5 months ago (2013-07-25 12:49:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/19593008/53001
7 years, 5 months ago (2013-07-26 00:13:44 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 08:02:23 UTC) #8
Message was sent while issue was closed.
Change committed as 213788

Powered by Google App Engine
This is Rietveld 408576698