Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 19591002: Minor cleanups to includes and fwd decls in core/css/resolver (Closed)

Created:
7 years, 5 months ago by Timothy Loh
Modified:
7 years, 5 months ago
CC:
blink-reviews, kenneth.christiansen, gavinp+prerender_chromium.org, chromiumbugtracker_adobe.com, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Minor cleanups to includes and fwd decls in core/css/resolver Remove some unneeded includes/fwd decls in core/css/resolver, and add some needed ones that were transitively included. IWYU suggests adding a heap more includes, but since we probably won't have any automated IWYU checks any time soon these will probably just end up as unused includes again. BUG=242216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154412

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -212 lines) Patch
M Source/core/css/CSSFontSelector.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/FontLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 1 2 1 chunk +12 lines, -59 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +7 lines, -54 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +3 lines, -42 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 2 4 chunks +1 line, -23 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 2 chunks +1 line, -23 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
Source/core/dom/NodeRenderingContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Timothy Loh
7 years, 5 months ago (2013-07-17 14:01:30 UTC) #1
kenneth.r.christiansen
lgtm, nice clean up
7 years, 5 months ago (2013-07-17 14:03:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/19591002/2001
7 years, 5 months ago (2013-07-17 16:00:10 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/css/resolver/MatchResult.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-17 16:00:30 UTC) #4
tfarina
Please, don't forget to fill BUG=242216
7 years, 5 months ago (2013-07-17 16:12:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/19591002/13001
7 years, 5 months ago (2013-07-17 16:18:46 UTC) #6
eseidel
lgtm
7 years, 5 months ago (2013-07-17 16:39:59 UTC) #7
eseidel
Thanks so much for doing this!
7 years, 5 months ago (2013-07-17 16:40:14 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 18:48:18 UTC) #9
Message was sent while issue was closed.
Change committed as 154412

Powered by Google App Engine
This is Rietveld 408576698