Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: base/memory/discardable_memory_mac.cc

Issue 195863005: Use DiscardableMemoryManager on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compilation issues on non-Android platforms Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/discardable_memory_linux.cc ('k') | base/memory/discardable_memory_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/discardable_memory_mac.cc
diff --git a/base/memory/discardable_memory_mac.cc b/base/memory/discardable_memory_mac.cc
index 40a97392e955e1a740171f82ffca6f9508fa3805..dc165167d0cb9c1f5ddd4f87832d1dae99c5806d 100644
--- a/base/memory/discardable_memory_mac.cc
+++ b/base/memory/discardable_memory_mac.cc
@@ -115,7 +115,7 @@ scoped_ptr<DiscardableMemory> DiscardableMemory::CreateLockedMemoryWithType(
DiscardableMemoryType type, size_t size) {
switch (type) {
case DISCARDABLE_MEMORY_TYPE_NONE:
- case DISCARDABLE_MEMORY_TYPE_ANDROID:
+ case DISCARDABLE_MEMORY_TYPE_ASHMEM:
return scoped_ptr<DiscardableMemory>();
case DISCARDABLE_MEMORY_TYPE_MAC: {
scoped_ptr<DiscardableMemoryMac> memory(new DiscardableMemoryMac(size));
@@ -147,15 +147,31 @@ scoped_ptr<DiscardableMemory> DiscardableMemory::CreateLockedMemoryWithType(
}
// static
-bool DiscardableMemory::PurgeForTestingSupported() {
- return true;
+bool DiscardableMemory::PurgeForTestingSupported(DiscardableMemoryType type) {
+ switch (type) {
+ case DISCARDABLE_MEMORY_TYPE_EMULATED:
+ case DISCARDABLE_MEMORY_TYPE_MAC:
+ return true;
+ default:
+ return false;
+ }
}
// static
-void DiscardableMemory::PurgeForTesting() {
- int state = 0;
- vm_purgable_control(mach_task_self(), 0, VM_PURGABLE_PURGE_ALL, &state);
- internal::DiscardableMemoryEmulated::PurgeForTesting();
+void DiscardableMemory::PurgeForTesting(DiscardableMemoryType type) {
+ switch (type) {
+ case DISCARDABLE_MEMORY_TYPE_EMULATED:
+ internal::DiscardableMemoryEmulated::PurgeForTesting();
+ return;
+ case DISCARDABLE_MEMORY_TYPE_MAC: {
+ int state = 0;
+ vm_purgable_control(mach_task_self(), 0, VM_PURGABLE_PURGE_ALL, &state);
+ internal::DiscardableMemoryEmulated::PurgeForTesting();
reveman 2014/04/28 16:02:24 if we add a type parameter then we shouldn't purge
Philippe 2014/04/28 16:31:22 Yes, that was a mistake. I got rid of the type tho
+ return;
+ }
+ default:
+ NOTREACHED();
+ }
}
} // namespace base
« no previous file with comments | « base/memory/discardable_memory_linux.cc ('k') | base/memory/discardable_memory_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698