chrome/browser/extensions/extension_service_unittest.cc - Issue 195813007: Remove ExtensionService::IsExternalExtensionUninstalled()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 195813007: Remove ExtensionService::IsExternalExtensionUninstalled() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/extension_sync_service.cc » ('j') | extensions/browser/pending_extension_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index ab5bfe9358ba223f48a1981be88e8558c3d33f52..cd853db84155916773d28009a5c0281e2edc3ded 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -5734,7 +5734,8 @@ TEST_F(ExtensionServiceTest, SyncForUninstalledExternalExtension) {

scoped_ptr<syncer::SyncErrorFactory>(new syncer::SyncErrorFactoryMock()));

UninstallExtension(good_crx, false);

- EXPECT_TRUE(service_->IsExternalExtensionUninstalled(good_crx));

+ EXPECT_TRUE(ExtensionPrefs::Get(profile_.get())

+ ->IsExternalExtensionUninstalled(good_crx));

sync_pb::EntitySpecifics specifics;

sync_pb::AppSpecifics* app_specifics = specifics.mutable_app();

@@ -5753,7 +5754,8 @@ TEST_F(ExtensionServiceTest, SyncForUninstalledExternalExtension) {

list[0] = sync_change;

extension_sync_service_->ProcessSyncChanges(FROM_HERE, list);

- EXPECT_TRUE(service_->IsExternalExtensionUninstalled(good_crx));

+ EXPECT_TRUE(ExtensionPrefs::Get(profile_.get())

+ ->IsExternalExtensionUninstalled(good_crx));

}

TEST_F(ExtensionServiceTest, GetSyncAppDataUserSettings) {