Issue 19579010: Remove unnecessary SupportsWeakPtr base from ChromotingInstance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19579010: Remove unnecessary SupportsWeakPtr base from ChromotingInstance. (Closed)

Created:
7 years, 5 months ago by Wez

Modified:
7 years, 5 months ago

Reviewers:
Sergey Ulanov, rmsousa

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary SupportsWeakPtr base from ChromotingInstance. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213346

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	remoting/client/plugin/chromoting_instance.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	remoting/client/plugin/chromoting_instance.cc	View		5 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/19579010/1

7 years, 5 months ago (2013-07-24 00:04:46 UTC) #4

Message was sent while issue was closed.

Change committed as 213346

Expand Messages | Collapse Messages