Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: chrome/browser/content_settings/content_settings_browsertest.cc

Issue 1957643002: media: Move widevine CDM targets to WidevineCdm folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: @loader_path/. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_browsertest.cc
diff --git a/chrome/browser/content_settings/content_settings_browsertest.cc b/chrome/browser/content_settings/content_settings_browsertest.cc
index 1d1349c1f96368ce84f8a3166542f94edcebeeb1..f5bbfac77c6cd8fa05c17e93fdc2d689253975da 100644
--- a/chrome/browser/content_settings/content_settings_browsertest.cc
+++ b/chrome/browser/content_settings/content_settings_browsertest.cc
@@ -322,27 +322,30 @@ class PepperContentSettingsSpecialCasesTest : public ContentSettingsTest {
// Registers any CDM plugins not registered by default.
void SetUpCommandLine(base::CommandLine* command_line) override {
#if defined(ENABLE_PEPPER_CDMS)
- // Platform-specific filename relative to the chrome executable.
+ // Base path for Clear Key CDM (relative to the chrome executable).
+ const char kClearKeyCdmBaseDirectory[] = "ClearKeyCdm";
+
+// Platform-specific filename relative to kClearKeyCdmBaseDirectory.
#if defined(OS_WIN)
- const char kLibraryName[] = "clearkeycdmadapter.dll";
+ const char kClearKeyCdmAdapterFileName[] = "clearkeycdmadapter.dll";
#else // !defined(OS_WIN)
#if defined(OS_MACOSX)
- const char kLibraryName[] = "clearkeycdmadapter.plugin";
+ const char kClearKeyCdmAdapterFileName[] = "clearkeycdmadapter.plugin";
#elif defined(OS_POSIX)
- const char kLibraryName[] = "libclearkeycdmadapter.so";
+ const char kClearKeyCdmAdapterFileName[] = "libclearkeycdmadapter.so";
#endif // defined(OS_MACOSX)
#endif // defined(OS_WIN)
// Append the switch to register the External Clear Key CDM.
base::FilePath::StringType pepper_plugins = BuildPepperPluginRegistration(
- kLibraryName, "Clear Key CDM", kExternalClearKeyMimeType);
+ kClearKeyCdmBaseDirectory, kClearKeyCdmAdapterFileName, "Clear Key CDM",
+ kExternalClearKeyMimeType);
#if defined(WIDEVINE_CDM_AVAILABLE) && defined(WIDEVINE_CDM_IS_COMPONENT)
// The CDM must be registered when it is a component.
pepper_plugins.append(FILE_PATH_LITERAL(","));
- pepper_plugins.append(
- BuildPepperPluginRegistration(kWidevineCdmAdapterFileName,
- kWidevineCdmDisplayName,
- kWidevineCdmPluginMimeType));
+ pepper_plugins.append(BuildPepperPluginRegistration(
+ kWidevineCdmBaseDirectory, kWidevineCdmAdapterFileName,
+ kWidevineCdmDisplayName, kWidevineCdmPluginMimeType));
#endif // defined(WIDEVINE_CDM_AVAILABLE) && defined(WIDEVINE_CDM_IS_COMPONENT)
command_line->AppendSwitchNative(switches::kRegisterPepperPlugins,
pepper_plugins);
@@ -434,11 +437,13 @@ class PepperContentSettingsSpecialCasesTest : public ContentSettingsTest {
// plugin using the provided parameters and a dummy version.
// Multiple results may be passed to kRegisterPepperPlugins, separated by ",".
base::FilePath::StringType BuildPepperPluginRegistration(
+ const char* library_path,
const char* library_name,
const char* display_name,
const char* mime_type) {
base::FilePath plugin_dir;
EXPECT_TRUE(PathService::Get(base::DIR_MODULE, &plugin_dir));
+ plugin_dir = plugin_dir.AppendASCII(library_path);
base::FilePath plugin_lib = plugin_dir.AppendASCII(library_name);
EXPECT_TRUE(base::PathExists(plugin_lib));

Powered by Google App Engine
This is Rietveld 408576698