Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 19574002: Refactoring: Introduce ResouceLoaderHost interface for unloading ResourceLoader. (Closed)

Created:
7 years, 5 months ago by Hajime Morrita
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, Nate Chapin
Visibility:
Public.

Description

Refactoring: Introduce ResouceLoaderHost interface for unloading ResourceLoader. This moves several direct dependencies of ResourceLoader into newly inroduced ResouceLoaderHost interface, which is implemented by CachedResourceLoader. The motivation here is to make ResourceLoader working without DocumentLoader and FrameLoader so that scripts can be loaded through imported documents, which doesn't have a DocumentLoader. Note that CachedResourceLoader already lives without DocumentLoader in some case, thus it is natural to localize such kind of complication there and keep ResourceLoader straightforward. BUG=240592 TEST=none R=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154452 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154471

Patch Set 1 #

Total comments: 2

Patch Set 2 : For re-landing through CQ #

Patch Set 3 : Fixed mac build failure. #

Patch Set 4 : Another attempt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -76 lines) Patch
M Source/core/css/CSSFontSelector.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/loader/ResourceLoader.h View 1 4 chunks +7 lines, -10 lines 0 comments Download
M Source/core/loader/ResourceLoader.cpp View 1 16 chunks +33 lines, -55 lines 0 comments Download
A Source/core/loader/ResourceLoaderHost.h View 1 2 3 1 chunk +83 lines, -0 lines 0 comments Download
M Source/core/loader/cache/CachedResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/cache/CachedResourceLoader.h View 1 2 5 chunks +31 lines, -6 lines 0 comments Download
M Source/core/loader/cache/CachedResourceLoader.cpp View 1 4 chunks +118 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Hajime Morrita
PTAL?
7 years, 5 months ago (2013-07-17 12:31:22 UTC) #1
dglazkov
+japhet.
7 years, 5 months ago (2013-07-17 16:03:35 UTC) #2
Nate Chapin
LGTM! I've been meaning to do something like this since blink day, I just hadn't ...
7 years, 5 months ago (2013-07-17 16:17:07 UTC) #3
Hajime Morrita
Thanks for taking a look! Will land now. On 2013/07/17 16:17:07, Nate Chapin wrote: > ...
7 years, 5 months ago (2013-07-18 01:10:33 UTC) #4
Hajime Morrita
Committed patchset #1 manually as r154452 (presubmit successful).
7 years, 5 months ago (2013-07-18 01:12:04 UTC) #5
tkent
On 2013/07/18 01:12:04, morrita1 wrote: > Committed patchset #1 manually as r154452 (presubmit successful). I ...
7 years, 5 months ago (2013-07-18 02:14:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/19574002/9001
7 years, 5 months ago (2013-07-18 03:03:03 UTC) #7
Hajime Morrita
On 2013/07/18 02:14:12, tkent wrote: > On 2013/07/18 01:12:04, morrita1 wrote: > > Committed patchset ...
7 years, 5 months ago (2013-07-18 03:03:38 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-18 03:26:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/19574002/23001
7 years, 5 months ago (2013-07-18 04:07:42 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-18 04:32:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/19574002/30001
7 years, 5 months ago (2013-07-18 04:55:17 UTC) #12
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 06:14:19 UTC) #13
Message was sent while issue was closed.
Change committed as 154471

Powered by Google App Engine
This is Rietveld 408576698