Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 19569012: Turn on -Wall -Wextra on Mac, and fix all the warnings that crop up for /usr/bin/g++ and Clang 3.3. (Closed)

Created:
7 years, 5 months ago by mtklein
Modified:
7 years, 5 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Turn on -Wall -Wextra on Mac, and fix all the warnings that crop up for /usr/bin/g++ and Clang 3.3. BUG= Committed: http://code.google.com/p/skia/source/detail?r=10255

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M bench/PathIterBench.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/mac/SkOptionsTableView.mm View 8 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
7 years, 5 months ago (2013-07-22 22:19:29 UTC) #1
bungeman-skia
lgtm
7 years, 5 months ago (2013-07-22 22:43:52 UTC) #2
bungeman-skia
My one super nit. https://codereview.chromium.org/19569012/diff/1/bench/PathIterBench.cpp File bench/PathIterBench.cpp (right): https://codereview.chromium.org/19569012/diff/1/bench/PathIterBench.cpp#newcode75 bench/PathIterBench.cpp:75: while ((verb = iter.next(pts)) != ...
7 years, 5 months ago (2013-07-22 22:44:12 UTC) #3
mtklein
https://codereview.chromium.org/19569012/diff/1/bench/PathIterBench.cpp File bench/PathIterBench.cpp (right): https://codereview.chromium.org/19569012/diff/1/bench/PathIterBench.cpp#newcode75 bench/PathIterBench.cpp:75: while ((verb = iter.next(pts)) != SkPath::kDone_Verb) {} On 2013/07/22 ...
7 years, 5 months ago (2013-07-22 22:47:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/19569012/6001
7 years, 5 months ago (2013-07-23 02:05:43 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 11:14:00 UTC) #6
Message was sent while issue was closed.
Change committed as 10255

Powered by Google App Engine
This is Rietveld 408576698