Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 19569006: Use a direct include of the message_loop header in chrome/test/, chrome/tools/, chrome/utility/. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, tfarina, kkania, frankf, chrome-speed-team+watch_google.com, anantha, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Use a direct include of the message_loop header in chrome/test/, chrome/tools/, chrome/utility/. BUG=260807 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M chrome/test/base/browser_with_test_window_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_test_utils_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_test_utils_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_test_utils_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/tracing.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/tracing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/command_executor_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/net_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/test_http_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/websocket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/generate_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/perf_ui_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/ipclist/ipcfuzz.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/service_discovery_sniffer/service_discovery_sniffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/firefox3_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/local_discovery/service_discovery_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19569006/1
7 years, 5 months ago (2013-07-17 14:45:30 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=136472
7 years, 5 months ago (2013-07-17 17:22:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19569006/1
7 years, 5 months ago (2013-07-17 17:52:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=60673
7 years, 5 months ago (2013-07-17 22:59:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/19569006/1
7 years, 5 months ago (2013-07-18 01:38:35 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 02:33:28 UTC) #6
Message was sent while issue was closed.
Change committed as 212216

Powered by Google App Engine
This is Rietveld 408576698