Issue 19564009: Adding pnacl translator to chrome-*.zip for dev builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19564009: Adding pnacl translator to chrome-*.zip for dev builds. (Closed)

Created:
7 years, 5 months ago by bradn

Modified:
7 years, 5 months ago

Reviewers:
jvoung (off chromium), Michael Moss, kerz_chromium

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Adding pnacl translator to chrome-*.zip for dev builds. This will make it easier to download a dev build of chromium with the pnacl translator baked in (we're already building but not archiving it). The translator will continue to be shipped to the public via components. This is just a debugging aid. BUG=None TEST=None R=mmoss@chromium.org,jvoung@chromium.org,kerz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212791

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	chrome/tools/build/linux/FILES.cfg	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/tools/build/mac/FILES.cfg	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/tools/build/win/FILES.cfg	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

bradn

On a related note, does anyone know why the locales on windows are called out ...

7 years, 5 months ago (2013-07-18 18:18:25 UTC) #1

jvoung (off chromium)

Thanks! pnacl build-output directory name LGTM

7 years, 5 months ago (2013-07-18 18:25:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/19564009/1

7 years, 5 months ago (2013-07-19 23:04:12 UTC) #4

Message was sent while issue was closed.

Change committed as 212791