Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: media/base/video_renderer.h

Issue 1955843002: Move Renderer permanent callbacks into RendererClient interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/renderer_client.h ('k') | media/mojo/services/mojo_renderer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_renderer.h
diff --git a/media/base/video_renderer.h b/media/base/video_renderer.h
index ddd47777daa5d4133fb8a66faf6e64a00fe141a8..bc7c1efbd101b932c4271c3cb0aa58766fc74695 100644
--- a/media/base/video_renderer.h
+++ b/media/base/video_renderer.h
@@ -5,11 +5,8 @@
#ifndef MEDIA_BASE_VIDEO_RENDERER_H_
#define MEDIA_BASE_VIDEO_RENDERER_H_
-#include "base/callback.h"
+#include "base/callback_forward.h"
#include "base/macros.h"
-#include "base/memory/ref_counted.h"
-#include "base/time/time.h"
-#include "media/base/buffering_state.h"
#include "media/base/media_export.h"
#include "media/base/pipeline_status.h"
#include "media/base/time_source.h"
@@ -18,51 +15,29 @@ namespace media {
class CdmContext;
class DemuxerStream;
-class VideoDecoder;
-class VideoFrame;
+class RendererClient;
class MEDIA_EXPORT VideoRenderer {
public:
- // Used to paint VideoFrame.
- typedef base::Callback<void(const scoped_refptr<VideoFrame>&)> PaintCB;
-
VideoRenderer();
// Stops all operations and fires all pending callbacks.
virtual ~VideoRenderer();
// Initializes a VideoRenderer with |stream|, executing |init_cb| upon
- // completion. If initialization fails, only |init_cb| (not |error_cb|) will
- // be called.
+ // completion. If initialization fails, only |init_cb|
+ // (not RendererClient::OnError) will be called.
//
// |cdm_context| can be used to handle encrypted streams. May be null if the
// stream is not encrypted.
//
- // |statistics_cb| is executed periodically with video rendering stats, such
- // as dropped frames.
- //
- // |buffering_state_cb| is executed when video rendering has either run out of
- // data or has enough data to continue playback.
- //
- // |ended_cb| is executed when video rendering has reached the end of stream.
- //
- // |error_cb| is executed if an error was encountered after initialization.
- //
// |wall_clock_time_cb| is used to convert media timestamps into wallclock
// timestamps.
- //
- // |waiting_for_decryption_key_cb| is executed whenever the key needed to
- // decrypt the stream is not available.
- virtual void Initialize(
- DemuxerStream* stream,
- const PipelineStatusCB& init_cb,
- CdmContext* cdm_context,
- const StatisticsCB& statistics_cb,
- const BufferingStateCB& buffering_state_cb,
- const base::Closure& ended_cb,
- const PipelineStatusCB& error_cb,
- const TimeSource::WallClockTimeCB& wall_clock_time_cb,
- const base::Closure& waiting_for_decryption_key_cb) = 0;
+ virtual void Initialize(DemuxerStream* stream,
+ CdmContext* cdm_context,
+ RendererClient* client,
+ const TimeSource::WallClockTimeCB& wall_clock_time_cb,
+ const PipelineStatusCB& init_cb) = 0;
// Discards any video data and stops reading from |stream|, executing
// |callback| when completed.
« no previous file with comments | « media/base/renderer_client.h ('k') | media/mojo/services/mojo_renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698