Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: Source/core/dom/ViewportArguments.h

Issue 19555002: Translate viewport related meta tags into @viewport descriptors as suggested by the CSS Device Adap… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ViewportArguments.h
diff --git a/Source/core/dom/ViewportArguments.h b/Source/core/dom/ViewportArguments.h
index ae3e94fd672977fe8f8b6e6b1bb5f83acea3ab26..0c21064a620f67f457bcdc6ee7afae55c2f89d42 100644
--- a/Source/core/dom/ViewportArguments.h
+++ b/Source/core/dom/ViewportArguments.h
@@ -36,30 +36,10 @@ namespace WebCore {
class Document;
-enum ViewportErrorCode {
- UnrecognizedViewportArgumentKeyError,
- UnrecognizedViewportArgumentValueError,
- TruncatedViewportArgumentValueError,
- MaximumScaleTooLargeError,
- TargetDensityDpiUnsupported
-};
-
struct ViewportArguments {
- enum Type {
- // These are ordered in increasing importance.
- Implicit,
- XHTMLMobileProfile,
- HandheldFriendlyMeta,
- MobileOptimizedMeta,
- ViewportMeta,
- CSSDeviceAdaptation
- } type;
-
enum {
ValueAuto = -1,
- ValueDeviceWidth = -2,
- ValueDeviceHeight = -3,
ValuePortrait = -4,
ValueLandscape = -5,
ValueDeviceDPI = -6,
@@ -69,12 +49,9 @@ struct ViewportArguments {
ValueExtendToZoom = -10
};
- ViewportArguments(Type type = Implicit)
- : type(type)
- , width(ValueAuto)
- , minWidth(ValueAuto)
+ ViewportArguments()
+ : minWidth(ValueAuto)
, maxWidth(ValueAuto)
- , height(ValueAuto)
, minHeight(ValueAuto)
, maxHeight(ValueAuto)
, zoom(ValueAuto)
@@ -86,13 +63,10 @@ struct ViewportArguments {
{
}
- // All arguments are in CSS units.
- PageScaleConstraints resolve(const FloatSize& initialViewportSize, int defaultWidth) const;
+ PageScaleConstraints resolve(const FloatSize& initialViewportSizeInCSSUnits) const;
- float width;
float minWidth;
float maxWidth;
- float height;
float minHeight;
float maxHeight;
float zoom;
@@ -104,12 +78,8 @@ struct ViewportArguments {
bool operator==(const ViewportArguments& other) const
{
- // Used for figuring out whether to reset the viewport or not,
- // thus we are not taking type into account.
- return width == other.width
- && minWidth == other.minWidth
+ return minWidth == other.minWidth
&& maxWidth == other.maxWidth
- && height == other.height
&& minHeight == other.minHeight
&& maxHeight == other.maxHeight
&& zoom == other.zoom
@@ -126,9 +96,6 @@ struct ViewportArguments {
}
};
-void setViewportFeature(const String& keyString, const String& valueString, Document*, void* data);
-void reportViewportWarning(Document*, ViewportErrorCode, const String& replacement1, const String& replacement2);
-
} // namespace WebCore
#endif // ViewportArguments_h

Powered by Google App Engine
This is Rietveld 408576698