Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 19552004: Improve description layout. Improve coloring and add legend in help. (Closed)

Created:
7 years, 5 months ago by M-A Ruel
Modified:
7 years, 5 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Improve description layout. Improve coloring and add legend in help. Convert monkey patching to class inheritance for OptionParser usage in: commit_queue.py, gclient.py and trychange.py. Monkey patching confuses the hell out of pylint. R=jochen@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=213423

Patch Set 1 #

Patch Set 2 : cleaner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -147 lines) Patch
M commit_queue.py View 1 3 chunks +18 lines, -22 lines 0 comments Download
M gclient.py View 4 chunks +51 lines, -46 lines 0 comments Download
M git_cl.py View 1 22 chunks +94 lines, -63 lines 0 comments Download
M tests/gclient_test.py View 10 chunks +10 lines, -10 lines 0 comments Download
M tests/trychange_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M trychange.py View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
All I wanted was to add a legend and all I got is this lousy ...
7 years, 5 months ago (2013-07-24 13:44:53 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-24 13:48:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/19552004/2001
7 years, 5 months ago (2013-07-24 13:54:54 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 13:56:50 UTC) #4
Message was sent while issue was closed.
Change committed as 213423

Powered by Google App Engine
This is Rietveld 408576698