chrome/common/extensions/extension_file_util.cc - Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_file_util.cc

Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: todo Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_constants.cc ('k') | chrome/common/extensions/manifest_handlers/shared_module_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_file_util.cc

diff --git a/chrome/common/extensions/extension_file_util.cc b/chrome/common/extensions/extension_file_util.cc

index 16b1e54f9fb742e80a0fd9718415f6ad3ca83d7b..29ed5ca81d51bfffe2ed8acf136c36b8813dd36c 100644

--- a/chrome/common/extensions/extension_file_util.cc

+++ b/chrome/common/extensions/extension_file_util.cc

@@ -18,7 +18,6 @@

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "base/threading/thread_restrictions.h"

-#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/extensions/api/extension_action/action_info.h"

#include "chrome/common/extensions/extension.h"

@@ -208,7 +207,7 @@ std::vector<base::FilePath> FindPrivateKeyFiles(

base::FileEnumerator::FILES);

for (base::FilePath current = traversal.Next(); !current.empty();

current = traversal.Next()) {

- if (!current.MatchesExtension(chrome::kExtensionKeyFileExtension))

+ if (!current.MatchesExtension(extensions::kExtensionKeyFileExtension))

continue;

std::string key_contents;