chrome/common/extensions/background_info.cc - Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/background_info.cc

Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: todo Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/background_info.cc

diff --git a/chrome/common/extensions/background_info.cc b/chrome/common/extensions/background_info.cc

index 8d21f5dafce9cd2fd0466e2cfe931938860c7534..ae257825f5856a5964f6e8cf41184575f10efd68 100644

--- a/chrome/common/extensions/background_info.cc

+++ b/chrome/common/extensions/background_info.cc

@@ -11,11 +11,11 @@

#include "base/strings/string_number_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/common/chrome_switches.h"

-#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_file_util.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/permissions/api_permission_set.h"

#include "chrome/common/extensions/permissions/permissions_data.h"

+#include "extensions/common/constants.h"

#include "extensions/common/error_utils.h"

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

@@ -57,8 +57,7 @@ GURL BackgroundInfo::GetBackgroundURL(const Extension* extension) {

const BackgroundInfo& info = GetBackgroundInfo(extension);

if (info.background_scripts_.empty())

return info.background_url_;

- return extension->GetResourceURL(

- extension_filenames::kGeneratedBackgroundPageFilename);

+ return extension->GetResourceURL(kGeneratedBackgroundPageFilename);

}

// static

« no previous file with comments | « chrome/common/chrome_constants.cc ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »