chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc - Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/sandboxed_unpacker.cc ('K') | « chrome/common/extensions/manifest_handlers/shared_module_info.cc ('k') | chrome/utility/extensions/unpacker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

index 7b49ccabd2480f7d91b0dba37de5cf7e7e27649e..a6fcab1fb8a44f168904b74f7a7a1e5f9cab78ae 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

@@ -13,6 +13,7 @@

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/features/base_feature_provider.h"

#include "chrome/common/extensions/features/feature.h"

+#include "extensions/common/constants.h"

#include "extensions/common/error_utils.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -46,7 +47,7 @@ TEST_F(ExtensionManifestBackgroundTest, BackgroundScripts) {

EXPECT_TRUE(BackgroundInfo::HasBackgroundPage(extension.get()));

EXPECT_EQ(

- std::string("/") + extension_filenames::kGeneratedBackgroundPageFilename,

+ std::string("/") + kGeneratedBackgroundPageFilename,

BackgroundInfo::GetBackgroundURL(extension.get()).path());

manifest->SetString("background_page", "monkey.html");