chrome/browser/extensions/pack_extension_job.cc - Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/pack_extension_job.cc

Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_protocols.cc ('k') | chrome/browser/extensions/sandboxed_unpacker.cc » ('j') | chrome/browser/extensions/sandboxed_unpacker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/pack_extension_job.cc

diff --git a/chrome/browser/extensions/pack_extension_job.cc b/chrome/browser/extensions/pack_extension_job.cc

index 744eb62a0f7f08212c1ebb20048b896a36f58a29..da182b18003fdf5248450233ff43e127836c246b 100644

--- a/chrome/browser/extensions/pack_extension_job.cc

+++ b/chrome/browser/extensions/pack_extension_job.cc

@@ -9,7 +9,7 @@

#include "base/strings/sys_string_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/extensions/extension_creator.h"

-#include "chrome/common/chrome_constants.h"

+#include "extensions/common/constants.h"

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

@@ -45,11 +45,11 @@ PackExtensionJob::~PackExtensionJob() {}

void PackExtensionJob::Run() {

crx_file_out_ = base::FilePath(root_directory_.value() +

- chrome::kExtensionFileExtension);

+ kExtensionFileExtension);

if (key_file_.empty())

key_file_out_ = base::FilePath(root_directory_.value() +

- chrome::kExtensionKeyFileExtension);

+ kExtensionKeyFileExtension);

// TODO(aa): Need to internationalize the errors that ExtensionCreator

// returns. See bug 20734.