Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

chrome/common/extensions/extension_file_util.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_file_util.h"
 
 #include <map>
 #include <vector>
 
 #include "base/file_util.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_restrictions.h"
-#include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "chrome/common/extensions/extension_l10n_util.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/extensions/manifest.h"
 #include "chrome/common/extensions/manifest_handler.h"
 #include "chrome/common/extensions/manifest_handlers/icons_handler.h"
@@ skipping 130 matching lines @@
   if (!ValidateExtension(extension.get(), error, &warnings))
     return NULL;
   extension->AddInstallWarnings(warnings);
 
   return extension;
 }
 
 base::DictionaryValue* LoadManifest(const base::FilePath& extension_path,
                                     std::string* error) {
   base::FilePath manifest_path =
-      extension_path.Append(extensions::kManifestFilename);
+      extension_path.Append(extensions::filenames::kManifestFilename);
   if (!base::PathExists(manifest_path)) {
     *error = l10n_util::GetStringUTF8(IDS_EXTENSION_MANIFEST_UNREADABLE);
     return NULL;
   }
 
   JSONFileValueSerializer serializer(manifest_path);
   scoped_ptr<base::Value> root(serializer.Deserialize(NULL, error));
   if (!root.get()) {
     if (error->empty()) {
       // If |error| is empty, than the file could not be read.
@@ skipping 18 matching lines @@
 }
 
 std::vector<base::FilePath> FindPrivateKeyFiles(
     const base::FilePath& extension_dir) {
   std::vector<base::FilePath> result;
   // Pattern matching only works at the root level, so filter manually.
   base::FileEnumerator traversal(extension_dir, /*recursive=*/true,
                                  base::FileEnumerator::FILES);
   for (base::FilePath current = traversal.Next(); !current.empty();
        current = traversal.Next()) {
-    if (!current.MatchesExtension(chrome::kExtensionKeyFileExtension))
+    if (!current.MatchesExtension(
+            extensions::filenames::kExtensionKeyFileExtension))
       continue;
 
     std::string key_contents;
     if (!file_util::ReadFileToString(current, &key_contents)) {
       // If we can't read the file, assume it's not a private key.
       continue;
     }
     std::string key_bytes;
     if (!Extension::ParsePEMKeyBytes(key_contents, &key_bytes)) {
       // If we can't parse the key, assume it's ok too.
@@ skipping 179 matching lines @@
     }
   }
 }
 
 extensions::MessageBundle* LoadMessageBundle(
     const base::FilePath& extension_path,
     const std::string& default_locale,
     std::string* error) {
   error->clear();
   // Load locale information if available.
-  base::FilePath locale_path = extension_path.Append(extensions::kLocaleFolder);
+  base::FilePath locale_path =
+      extension_path.Append(extensions::filenames::kLocaleFolder);
   if (!base::PathExists(locale_path))
     return NULL;
 
   std::set<std::string> locales;
   if (!extension_l10n_util::GetValidLocales(locale_path, &locales, error))
     return NULL;
 
   if (default_locale.empty() ||
       locales.find(default_locale) == locales.end()) {
     *error = l10n_util::GetStringUTF8(
@@ skipping 32 matching lines @@
   returnValue->insert(
       std::make_pair(extensions::MessageBundle::kExtensionIdKey, extension_id));
 
   return returnValue;
 }
 
 bool CheckForIllegalFilenames(const base::FilePath& extension_path,
                               std::string* error) {
   // Reserved underscore names.
   static const base::FilePath::CharType* reserved_names[] = {
-    extensions::kLocaleFolder,
-    extensions::kPlatformSpecificFolder,
+    extensions::filenames::kLocaleFolder,
+    extensions::filenames::kPlatformSpecificFolder,
     FILE_PATH_LITERAL("__MACOSX"),
   };
   CR_DEFINE_STATIC_LOCAL(
       std::set<base::FilePath::StringType>, reserved_underscore_names,
       (reserved_names, reserved_names + arraysize(reserved_names)));
 
   // Enumerate all files and directories in the extension root.
   // There is a problem when using pattern "_*" with FileEnumerator, so we have
   // to cheat with find_first_of and match all.
   const int kFilesAndDirectories =
@@ skipping 91 matching lines @@
     return base::FilePath();
   }
   return temp_path;
 }
 
 void DeleteFile(const base::FilePath& path, bool recursive) {
   base::DeleteFile(path, recursive);
 }
 
 }  // namespace extension_file_util