Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

chrome/browser/download/download_target_determiner.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_target_determiner.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/download/download_extensions.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/download/download_util.h"
 #include "chrome/browser/extensions/webstore_installer.h"
 #include "chrome/browser/history/history_service.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/feature_switch.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/download_interrupt_reasons.h"
+#include "extensions/common/constants.h"
 #include "grit/generated_resources.h"
 #include "net/base/net_util.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using content::BrowserThread;
 using content::DownloadItem;
 
 namespace {
 
 const base::FilePath::CharType kCrdownloadSuffix[] =
@@ skipping 508 matching lines @@
     return true;
 
   // Check if the user has the "Always prompt for download location" preference
   // set. If so we prompt for most downloads except for the following scenarios:
   // 1) Extension installation. Note that we only care here about the case where
   //    an extension is installed, not when one is downloaded with "save as...".
   // 2) Filetypes marked "always open." If the user just wants this file opened,
   //    don't bother asking where to keep it.
   if (download_prefs_->PromptForDownload() &&
       !download_crx_util::IsExtensionDownload(*download_) &&
-      !extensions::Extension::IsExtension(filename) &&
+      !filename.MatchesExtension(extensions::kExtensionFileExtension) &&
       !download_prefs_->IsAutoOpenEnabledBasedOnExtension(filename))
     return true;
 
   // Otherwise, don't prompt. Note that the user might still be prompted if
   // there are unresolved conflicts during path reservation (e.g. due to the
   // target path being unwriteable or because there are too many conflicting
   // files), or if an extension signals that the user be prompted on a filename
   // conflict.
   return false;
 }
@@ skipping 78 matching lines @@
   // asynchronously.
   new DownloadTargetDeterminer(download, initial_virtual_path, download_prefs,
                                delegate, callback);
 }
 
 // static
 base::FilePath DownloadTargetDeterminer::GetCrDownloadPath(
     const base::FilePath& suggested_path) {
   return base::FilePath(suggested_path.value() + kCrdownloadSuffix);
 }