Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 19541009: Fix build problem with reverted issue 16948011 (Closed)

Created:
7 years, 5 months ago by sglez
Modified:
7 years, 5 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix build problem with reverted issue 16948011 BUG= Committed: http://code.google.com/p/skia/source/detail?r=10201

Patch Set 1 #

Patch Set 2 : remove constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -1 line) Patch
M gyp/tools.gyp View 2 chunks +23 lines, -1 line 0 comments Download
A tools/bbh_shootout.cpp View 1 1 chunk +385 lines, -0 lines 0 comments Download
A tools/lua/bbh_filter.lua View 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 5 months ago (2013-07-19 15:55:12 UTC) #1
sglez
Hi Cary, The commit bot is not commiting. Maybe it needs a lgtm?
7 years, 5 months ago (2013-07-19 17:54:51 UTC) #2
caryclark
lgtm
7 years, 5 months ago (2013-07-19 18:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sglez@google.com/19541009/3001
7 years, 5 months ago (2013-07-19 18:14:19 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-19 18:54:06 UTC) #5
Message was sent while issue was closed.
Change committed as 10201

Powered by Google App Engine
This is Rietveld 408576698